lkml.org 
[lkml]   [2022]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] arm64: dts: marvell: Fix compatible strings for Armada 3720 boards
    On Wednesday 13 July 2022 21:42:43 Krzysztof Kozlowski wrote:
    > On 13/07/2022 14:56, Pali Rohár wrote:
    > > All Armada 3720 boards have Armada 3720 processor which is of Armada 3700
    > > family and do not have Armada 3710 processor. So none of them should have
    > > compatible string for Armada 3710 processor.
    > >
    > > Fix compatible string for all these boards by removing wrong processor
    > > string "marvell,armada3710" and adding family string "marvell,armada3700"
    > > as the last one. (Note that this is same way how are defined Armada 3710
    > > DTS files).
    >
    > Please do not introduce some changes just in DTS, but start from the
    > bindings. Someone wrote the bindings like that and expected to be that
    > way, so first change the bindings with proper rationale. Then change the
    > DTS files.
    >
    >
    > Best regards,
    > Krzysztof

    Ok, I tried to update bindings and fix example in it, see patch:
    https://lore.kernel.org/linux-devicetree/20220713200123.22612-1-pali@kernel.org/

    \
     
     \ /
      Last update: 2022-07-13 22:05    [W:4.574 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site