lkml.org 
[lkml]   [2022]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 1/1] virt: acrn: Mark the uuid field as unused
On Wed, Jul 13, 2022 at 7:21 PM Andy Shevchenko
<andriy.shevchenko@linux.intel.com> wrote:
>
> On Wed, Jul 13, 2022 at 07:10:18PM +0200, Rafael J. Wysocki wrote:
> > On Wed, Jul 13, 2022 at 7:03 PM Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com> wrote:
> > >
> > > After the commits for userspace [1][2] the uuid field is not being
> > > used in the ACRN code. Update kernel to reflect these changes.
> > > I.e. we do the following:
> > > - adding a comment explaining that it's not used anymore
> > > - replacing the specific type by a raw buffer
> > > - updating the example code accordingly
> > >
> > > [1]: https://github.com/projectacrn/acrn-hypervisor/commit/da0d24326ed6
> > > [2]: https://github.com/projectacrn/acrn-hypervisor/commit/bb0327e70097
> >
> > Why don't you use a Link tag for each of these?
>
> I can use Link tags.
>
> > > Fixes: 5b06931d7f8b ("sample/acrn: Introduce a sample of HSM ioctl interface usage")
> > > Fixes: 9c5137aedd11 ("virt: acrn: Introduce VM management interfaces")
> >
> > Typically, the changelog should explain what was wrong in a previous
> > commit that is being fixed in the current one, but that information is
> > missing here.
>
> The advertised field confused users and actually never been used. So
> the wrong part here is that kernel puts something which userspace
> never used and hence this may confuse a reader of this code.
>
> Would it be sufficient? Another way is to drop Fixes tag.

Yes, it would.

\
 
 \ /
  Last update: 2022-07-13 19:39    [W:0.046 / U:0.484 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site