Messages in this thread | | | Date | Wed, 13 Jul 2022 09:36:37 -0700 | Subject | Re: [PATCH v2 5/8] arm: bcmbca: Move BCM63138 ARCH_BCM_63XX to ARCH_BCMBCA | From | Florian Fainelli <> |
| |
On 7/13/22 08:31, Rafał Miłecki wrote: > On 7.07.2022 09:00, William Zhang wrote: >> Remove ARCH_BCM_63XX Kconfig for BCM63138 and merge its selections to >> ARCH_BCMBCA. Delete bcm63xx.c as it is no longer needed. >> >> Signed-off-by: William Zhang <william.zhang@broadcom.com> > > What about ARCH_BCM_63XX references in > 1. arch/arm/Kconfig.debug
That one was dealt with:
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=fa0ef5a086a05306fc5322bbda73459725eda923
> 2. arch/arm/configs/multi_v7_defconfig
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?id=a65ee523a9e41d0bf046cf0107e6bbf05d068af2
patch 8/8 of this series
> > Did you handle them in some other patchset? > > > This change is probably going to break "make oldconfig" for users. Is > there any kernel policy for that? Do we care about it? Should we leave > old symbol as hidden and make ARCH_BCMBCA auto-selected if it's set?
I do not believe anyone but me was enabling CONFIG_ARCH_BCM_63XX so this did not have any users until the BCA team decided to take over.
> > > Finally it'd probably be more clean to first introduce > ARCH_BCMBCA_CORTEXA9 and then get rid of ARCH_BCM_63XX.
That is fair, however a bit late now that the pull requests have been accepted by the soc maintainers.
Thanks! -- Florian
| |