Messages in this thread | | | Date | Tue, 12 Jul 2022 08:46:38 +0200 | Subject | Re: [PATCH v3] xen/gntdev: Ignore failure to unmap INVALID_GRANT_HANDLE | From | Juergen Gross <> |
| |
On 11.07.22 01:05, Demi Marie Obenour wrote: > The error paths of gntdev_mmap() can call unmap_grant_pages() even > though not all of the pages have been successfully mapped. This will > trigger the WARN_ON()s in __unmap_grant_pages_done(). The number of > warnings can be very large; I have observed thousands of lines of > warnings in the systemd journal. > > Avoid this problem by only warning on unmapping failure if the handle > being unmapped is not INVALID_GRANT_HANDLE. The handle field of any > page that was not successfully mapped will be INVALID_GRANT_HANDLE, so > this catches all cases where unmapping can legitimately fail. > > Suggested-by: Juergen Gross <jgross@suse.com> > Cc: stable@vger.kernel.org > Signed-off-by: Demi Marie Obenour <demi@invisiblethingslab.com> > Fixes: dbe97cff7dd9 ("xen/gntdev: Avoid blocking in unmap_grant_pages()")
Pushed to xen/tip.git for-linus-5.19a
Juergen [unhandled content-type:application/pgp-keys][unhandled content-type:application/pgp-signature] | |