lkml.org 
[lkml]   [2022]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v6 4/6] tpm: of: Make of-tree specific function commonly available
From


On 7/11/22 18:04, Mimi Zohar wrote:
> Hi Stefan,
>
> On Thu, 2022-07-07 at 13:20 -0400, Stefan Berger wrote:
>> - /*
>> - * For both vtpm/tpm, firmware has log addr and log size in big
>> - * endian format. But in case of vtpm, there is a method called
>> - * sml-handover which is run during kernel init even before
>> - * device tree is setup. This sml-handover function takes care
>> - * of endianness and writes to sml-base and sml-size in little
>> - * endian format. For this reason, vtpm doesn't need conversion
>> - * but physical tpm needs the conversion.
>> - */
>
> This comment is dropped. Perhaps not in such detail, but shouldn't a
> comment or function description exist in the new function.

I am adding back the comment in v7.

>
> Otherwise,
> Reviewed-by: Mimi Zohar <zohar@linux.ibm.com>
>
> thanks,
>
> Mimi
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec

\
 
 \ /
  Last update: 2022-07-12 15:25    [W:0.119 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site