Messages in this thread Patch in this message | | | From | Hangyu Hua <> | Subject | [PATCH] net: 9p: fix possible refcount leak in p9_read_work() | Date | Tue, 12 Jul 2022 18:44:38 +0800 |
| |
p9_req_put need to be called when m->rreq->rc.sdata is NULL to avoid possible refcount leak.
Fixes: 728356dedeff ("9p: Add refcount to p9_req_t") Signed-off-by: Hangyu Hua <hbh25y@gmail.com> ---
Add p9_req_put in the "No recv fcall for tag..." error path according to Dominique's suggestion.
net/9p/trans_fd.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/net/9p/trans_fd.c b/net/9p/trans_fd.c index 507974ce880c..090337f446d7 100644 --- a/net/9p/trans_fd.c +++ b/net/9p/trans_fd.c @@ -345,6 +345,7 @@ static void p9_read_work(struct work_struct *work) p9_debug(P9_DEBUG_ERROR, "No recv fcall for tag %d (req %p), disconnecting!\n", m->rc.tag, m->rreq); + p9_req_put(m->rreq); m->rreq = NULL; err = -EIO; goto error; -- 2.25.1
| |