lkml.org 
[lkml]   [2022]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 2/3] pinctrl: sunxi: add support for R329 CPUX pin controller
From
Date
在 2022-07-10星期日的 21:06 +0200,Andy Shevchenko写道:
> On Sun, Jul 10, 2022 at 10:22 AM Icenowy Zheng <uwu@icenowy.me>
> wrote:
> >
> > Allwinner R329 SoC has two pin controllers similar to ones on
> > previous
> > SoCs, one in CPUX power domain and another in CPUS.
> >
> > This patch adds support for the CPUX domain pin controller.
>
> ...
>
> > +#include <linux/module.h>
> > +#include <linux/platform_device.h>
>
> > +#include <linux/of.h>
> > +#include <linux/of_device.h>
>
> No use of these.
>
> > +#include <linux/pinctrl/pinctrl.h>
>
> Missed headers:
> mod_devicetable.h

Thanks for these.

In addition, how to decide what header should be included? The code
works properly because of_device.h includes mod_devicetable.h.

>
> > +#include "pinctrl-sunxi.h"
>


\
 
 \ /
  Last update: 2022-07-12 11:39    [W:0.052 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site