Messages in this thread | | | Date | Tue, 12 Jul 2022 11:03:05 +0200 | From | Gerd Hoffmann <> | Subject | Re: [PATCH 1/3] drm/fourcc: Add missing big-endian XRGB1555 and RGB565 formats |
| |
> > As described above DRM_FORMAT_HOST_RGB565 means bigendian on bigendian > > hosts and little endian on little endian hosts. Which is not correct > > when your hardware does big endian no matter what. > > But (a) drm_driver_legacy_fb_format() uses DRM_FORMAT_HOST_RGB565 > if quirk_addfb_prefer_host_byte_order is set,
Ah, right. Missed that in 'git grep' output. Given that traditional fbdev behavior is to expect native byte order using DRM_FORMAT_HOST_RGB565 there makes sense indeed.
Scratch my comment about it being unused then ;)
thanks, Gerd
| |