lkml.org 
[lkml]   [2022]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [PATCH v4 2/9] usb: typec: Add retimer handle to port
Mon, Jul 11, 2022 at 07:22:56AM +0000, Prashant Malani kirjoitti:
> Similar to mux and orientation switch, add a handle for registered
> retimer to the port, so that it has handles to the various switches
> connected to it.
>
> Signed-off-by: Prashant Malani <pmalani@chromium.org>

Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> ---
>
> Changes since v3:
> - No changes.
>
> Changes since v2:
> - No changes.
>
> Changes since v1:
> - Relinquish retimer reference during typec_release.
>
> drivers/usb/typec/class.c | 9 +++++++++
> drivers/usb/typec/class.h | 1 +
> 2 files changed, 10 insertions(+)
>
> diff --git a/drivers/usb/typec/class.c b/drivers/usb/typec/class.c
> index 9062836bb638..f08e32d552b4 100644
> --- a/drivers/usb/typec/class.c
> +++ b/drivers/usb/typec/class.c
> @@ -12,6 +12,7 @@
> #include <linux/slab.h>
> #include <linux/usb/pd_vdo.h>
> #include <linux/usb/typec_mux.h>
> +#include <linux/usb/typec_retimer.h>
>
> #include "bus.h"
> #include "class.h"
> @@ -1736,6 +1737,7 @@ static void typec_release(struct device *dev)
> ida_destroy(&port->mode_ids);
> typec_switch_put(port->sw);
> typec_mux_put(port->mux);
> + typec_retimer_put(port->retimer);
> kfree(port->cap);
> kfree(port);
> }
> @@ -2249,6 +2251,13 @@ struct typec_port *typec_register_port(struct device *parent,
> return ERR_PTR(ret);
> }
>
> + port->retimer = typec_retimer_get(&port->dev);
> + if (IS_ERR(port->retimer)) {
> + ret = PTR_ERR(port->retimer);
> + put_device(&port->dev);
> + return ERR_PTR(ret);
> + }
> +
> ret = device_add(&port->dev);
> if (ret) {
> dev_err(parent, "failed to register port (%d)\n", ret);
> diff --git a/drivers/usb/typec/class.h b/drivers/usb/typec/class.h
> index 43fcf9e37a8c..673b2952b074 100644
> --- a/drivers/usb/typec/class.h
> +++ b/drivers/usb/typec/class.h
> @@ -55,6 +55,7 @@ struct typec_port {
> enum typec_orientation orientation;
> struct typec_switch *sw;
> struct typec_mux *mux;
> + struct typec_retimer *retimer;
>
> const struct typec_capability *cap;
> const struct typec_operations *ops;
> --
> 2.37.0.144.g8ac04bfd2-goog

--
heikki

\
 
 \ /
  Last update: 2022-07-12 10:29    [W:0.205 / U:0.296 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site