lkml.org 
[lkml]   [2022]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v2 2/2] dt-binding: sound: atmel,pdmic: Convert to json-schema
From
On 11/07/2022 20:30, Ryan.Wanner@microchip.com wrote:
> From: Ryan Wanner <Ryan.Wanner@microchip.com>
>
> Convert Atmel PDMIC devicetree binding to json-schema.
> Change file naming to match json-schema naming.
>
> Signed-off-by: Ryan Wanner <Ryan.Wanner@microchip.com>
> ---
> v1 -> v2:
> - Fix title.
> - Removed trivial descriptions.
> - Fix formatting.
>
> .../bindings/sound/atmel,sama5d2-pdmic.yaml | 98 +++++++++++++++++++
> .../devicetree/bindings/sound/atmel-pdmic.txt | 55 -----------
> 2 files changed, 98 insertions(+), 55 deletions(-)
> create mode 100644 Documentation/devicetree/bindings/sound/atmel,sama5d2-pdmic.yaml
> delete mode 100644 Documentation/devicetree/bindings/sound/atmel-pdmic.txt
>
> diff --git a/Documentation/devicetree/bindings/sound/atmel,sama5d2-pdmic.yaml b/Documentation/devicetree/bindings/sound/atmel,sama5d2-pdmic.yaml
> new file mode 100644
> index 000000000000..88fa92a30147
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/sound/atmel,sama5d2-pdmic.yaml
> @@ -0,0 +1,98 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +# Copyright (C) 2022 Microchip Technology, Inc. and its subsidiaries
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/sound/atmel,sama5d2-pdmic.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Atmel PDMIC decoder
> +
> +maintainers:
> + - Claudiu Beznea <claudiu.beznea@microchip.com>
> +
> +description:
> + Atmel Pulse Density Modulation Interface Controller
> + (PDMIC) peripheral is a mono PDM decoder module
> + that decodes an incoming PDM sample stream.
> +
> +properties:
> + compatible:
> + const: atmel,sama5d2-pdmic
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + items:
> + - description: peripheral clock
> + - description: generated clock
> +
> + clock-names:
> + items:
> + - const: pclk
> + - const: gclk
> +
> + dmas:
> + maxItems: 1
> +
> + dma-names:
> + const: rx
> +
> + atmel,mic-min-freq:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + The minimal frequency that the microphone supports.
> +
> + atmel,mic-max-freq:
> + $ref: /schemas/types.yaml#/definitions/uint32
> + description:
> + The maximal frequency that the microphone supports.
> +
> + atmel,model:
> + description: The user-visible name of this sound card.

In previous properties the description was the last one, so keep it
consistent.

> + $ref: /schemas/types.yaml#/definitions/string
> + default: PDMIC
> +
> + atmel,mic-offset:
> + $ref: /schemas/types.yaml#/definitions/int32
> + description: The offset that should be added.
> + default: 0
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - dmas
> + - dma-names
> + - clock-names
> + - clocks
> + - atmel,mic-min-freq
> + - atmel,mic-max-freq
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/dma/at91.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + pdmic: sound@f8018000 {
> + compatible = "atmel,sama5d2-pdmic";

Wrong indentation. I already asked for this.


Best regards,
Krzysztof

\
 
 \ /
  Last update: 2022-07-12 10:15    [W:0.083 / U:0.320 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site