lkml.org 
[lkml]   [2022]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] sched/schedutil: Fix deadlock between cpuset and cpu hotplug when using schedutil
On Tue, Jul 12, 2022 at 10:49:57PM -0400, Waiman Long wrote:
> > Well, the only thing I can think of is always grabbing cpus_read_lock()
> > before grabbing threadgroup_rwsem. Waiman, what do you think?
>
> That is a possible solution as cpus_read_lock() is rather lightweight. It is
> a good practice to acquire it first.

On a similar note, I think we probably should re-enable percpu operations on
threadgroup_rwsem too by default and allow users who are affected by slower
write path operations to opt-in. After the new CLONE_INTO_CGROUP which
doesn't need the rwsem, we have far fewer write lockers after all.

Thanks.

--
tejun

\
 
 \ /
  Last update: 2022-07-13 05:02    [W:0.259 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site