lkml.org 
[lkml]   [2022]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH -next v2 1/3] spi: microchip-core: fix UAF in mchp_corespi_remove()
    Date
    When using devm_spi_register_master(), the unregister function will
    be called in devres_release_all() which is called after ->remove(),
    so remove spi_unregister_master() andspi_master_put().

    Fixes: 9ac8d17694b6 ("spi: add support for microchip fpga spi controllers")
    Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
    ---
    drivers/spi/spi-microchip-core.c | 2 --
    1 file changed, 2 deletions(-)

    diff --git a/drivers/spi/spi-microchip-core.c b/drivers/spi/spi-microchip-core.c
    index b3083075cd36..c26767343176 100644
    --- a/drivers/spi/spi-microchip-core.c
    +++ b/drivers/spi/spi-microchip-core.c
    @@ -595,8 +595,6 @@ static int mchp_corespi_remove(struct platform_device *pdev)
    struct mchp_corespi *spi = spi_master_get_devdata(master);

    mchp_corespi_disable_ints(spi);
    - spi_unregister_master(master);
    - spi_master_put(master);
    clk_disable_unprepare(spi->clk);
    mchp_corespi_disable(spi);

    --
    2.25.1
    \
     
     \ /
      Last update: 2022-07-13 04:48    [W:3.115 / U:0.544 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site