Messages in this thread | | | Date | Tue, 12 Jul 2022 17:59:50 -0700 | Subject | Re: [RFC PATCH 3/3] arm64: dts: bcmbca: update bcm4808 board dts file | From | William Zhang <> |
| |
On 7/12/22 11:20, Krzysztof Kozlowski wrote: > On 12/07/2022 19:48, William Zhang wrote: >>> >>> Best regards, >>> Krzysztof >> >> The reason for this patch is to keep the bcmbca board dts in the same >> format and keep everything in the same yaml file. > > Not a good reason to change compatibles. You can have the same format > and keep everything in same YAML file without replacing compatibles. > Well the existing 4908 compatible string is not the same format as we are proposing here: "board variant", "chip variant", "brcm, bcmbca"
>> Understand 4908 was >> already upstream but luckily there is no driver in linux and u-boot that >> uses these 4908 compatible strings. They are only used in the board dts >> as far as I can see. So it does not really break anything in the end, >> unless someone use them in any driver but never upstream their code... > > So maybe just briefly mention it in the commit msg? > I can do that for sure.
> Best regards, > Krzysztof [unhandled content-type:application/pkcs7-signature]
| |