Messages in this thread | | | From | Guenter Roeck <> | Date | Tue, 12 Jul 2022 15:07:59 -0700 | Subject | Re: [PATCH] platform/chrome: cros_ec_typec: Use dev_err_probe on port register fail |
| |
On Tue, Jul 12, 2022 at 2:46 PM Nícolas F. R. A. Prado <nfraprado@collabora.com> wrote: > > The typec_register_port() can fail with EPROBE_DEFER if the endpoint > node hasn't probed yet. In order to avoid spamming the log with errors > in that case, log using dev_err_probe(). > > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>
Reviewed-by: Guenter Roeck <groeck@chromium.org>
> > --- > > drivers/platform/chrome/cros_ec_typec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/platform/chrome/cros_ec_typec.c b/drivers/platform/chrome/cros_ec_typec.c > index d6088ba447af..8c0ca3c128ee 100644 > --- a/drivers/platform/chrome/cros_ec_typec.c > +++ b/drivers/platform/chrome/cros_ec_typec.c > @@ -352,8 +352,8 @@ static int cros_typec_init_ports(struct cros_typec_data *typec) > > cros_port->port = typec_register_port(dev, cap); > if (IS_ERR(cros_port->port)) { > - dev_err(dev, "Failed to register port %d\n", port_num); > ret = PTR_ERR(cros_port->port); > + dev_err_probe(dev, ret, "Failed to register port %d\n", port_num); > goto unregister_ports; > } > > -- > 2.37.0 >
| |