lkml.org 
[lkml]   [2022]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
Subjectarch/arm/mach-omap1/devices.c:230:24: sparse: sparse: symbol 'omap_spi1' was not declared. Should it be static?
Hi Stephen,

First bad commit (maybe != root cause):

tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 72a8e05d4f66b5af7854df4490e3135168694b6b
commit: 250c1a694ff304e5d69e74ab32755eddcc2b8f65 ARM: pxa: convert to multiplatform
date: 9 weeks ago
config: arm-randconfig-s031-20220712 (https://download.01.org/0day-ci/archive/20220713/202207130452.LSMR6iix-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 11.3.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# apt-get install sparse
# sparse version: v0.6.4-39-gce1a6720-dirty
# https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=250c1a694ff304e5d69e74ab32755eddcc2b8f65
git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
git fetch --no-tags linus master
git checkout 250c1a694ff304e5d69e74ab32755eddcc2b8f65
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' O=build_dir ARCH=arm SHELL=/bin/bash arch/arm/mach-iop32x/ arch/arm/mach-mmp/ arch/arm/mach-mv78xx0/ arch/arm/mach-omap1/ arch/arm/mach-orion5x/ arch/arm/mach-spear/ arch/arm/mm/ drivers/clk/spear/ drivers/isdn/hardware/mISDN/ drivers/net/ethernet/google/gve/ drivers/scsi/ drivers/usb/host/ sound/soc/codecs/

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>


sparse warnings: (new ones prefixed by >>)
>> arch/arm/mach-omap1/devices.c:230:24: sparse: sparse: symbol 'omap_spi1' was not declared. Should it be static?
>> arch/arm/mach-omap1/devices.c:235:24: sparse: sparse: symbol 'omap_spi2' was not declared. Should it be static?
>> arch/arm/mach-omap1/devices.c:245:37: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void *[addressable] [toplevel] platform_data @@ got void [noderef] __iomem * @@
arch/arm/mach-omap1/devices.c:245:37: sparse: expected void *[addressable] [toplevel] platform_data
arch/arm/mach-omap1/devices.c:245:37: sparse: got void [noderef] __iomem *
arch/arm/mach-omap1/devices.c:249:37: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void *[addressable] [toplevel] platform_data @@ got void [noderef] __iomem * @@
arch/arm/mach-omap1/devices.c:249:37: sparse: expected void *[addressable] [toplevel] platform_data
arch/arm/mach-omap1/devices.c:249:37: sparse: got void [noderef] __iomem *
--
>> arch/arm/mach-omap1/mcbsp.c:94:17: sparse: sparse: symbol 'omap7xx_mcbsp_res' was not declared. Should it be static?
arch/arm/mach-omap1/mcbsp.c:171:17: sparse: sparse: symbol 'omap15xx_mcbsp_res' was not declared. Should it be static?
>> arch/arm/mach-omap1/mcbsp.c:278:17: sparse: sparse: symbol 'omap16xx_mcbsp_res' was not declared. Should it be static?
--
>> drivers/usb/host/ohci-omap.c:231:31: sparse: sparse: Using plain integer as NULL pointer
drivers/usb/host/ohci-omap.c:353:56: sparse: sparse: Using plain integer as NULL pointer

vim +/omap_spi1 +230 arch/arm/mach-omap1/devices.c

c5c4dce45d7538 Cory Maccarrone 2010-01-08 229
c5c4dce45d7538 Cory Maccarrone 2010-01-08 @230 struct platform_device omap_spi1 = {
c5c4dce45d7538 Cory Maccarrone 2010-01-08 231 .name = "omap1_spi100k",
c5c4dce45d7538 Cory Maccarrone 2010-01-08 232 .id = 1,
c5c4dce45d7538 Cory Maccarrone 2010-01-08 233 };
c5c4dce45d7538 Cory Maccarrone 2010-01-08 234
c5c4dce45d7538 Cory Maccarrone 2010-01-08 @235 struct platform_device omap_spi2 = {
c5c4dce45d7538 Cory Maccarrone 2010-01-08 236 .name = "omap1_spi100k",
c5c4dce45d7538 Cory Maccarrone 2010-01-08 237 .id = 2,
c5c4dce45d7538 Cory Maccarrone 2010-01-08 238 };
c5c4dce45d7538 Cory Maccarrone 2010-01-08 239
c5c4dce45d7538 Cory Maccarrone 2010-01-08 240 static void omap_init_spi100k(void)
c5c4dce45d7538 Cory Maccarrone 2010-01-08 241 {
028baad5221e5f Aaro Koskinen 2018-11-19 242 if (!cpu_is_omap7xx())
028baad5221e5f Aaro Koskinen 2018-11-19 243 return;
028baad5221e5f Aaro Koskinen 2018-11-19 244
c5c4dce45d7538 Cory Maccarrone 2010-01-08 @245 omap_spi1.dev.platform_data = ioremap(OMAP7XX_SPI1_BASE, 0x7ff);
c5c4dce45d7538 Cory Maccarrone 2010-01-08 246 if (omap_spi1.dev.platform_data)
c5c4dce45d7538 Cory Maccarrone 2010-01-08 247 platform_device_register(&omap_spi1);
c5c4dce45d7538 Cory Maccarrone 2010-01-08 248
c5c4dce45d7538 Cory Maccarrone 2010-01-08 249 omap_spi2.dev.platform_data = ioremap(OMAP7XX_SPI2_BASE, 0x7ff);
c5c4dce45d7538 Cory Maccarrone 2010-01-08 250 if (omap_spi2.dev.platform_data)
c5c4dce45d7538 Cory Maccarrone 2010-01-08 251 platform_device_register(&omap_spi2);
c5c4dce45d7538 Cory Maccarrone 2010-01-08 252 }
c5c4dce45d7538 Cory Maccarrone 2010-01-08 253

:::::: The code at line 230 was first introduced by commit
:::::: c5c4dce45d7538ada6e9aac4cdb2909bc1cb28f6 omap1: Add 7xx clocks and pin muxes for SPI

:::::: TO: Cory Maccarrone <darkstar6262@gmail.com>
:::::: CC: Tony Lindgren <tony@atomide.com>

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-07-12 22:39    [W:0.098 / U:0.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site