Messages in this thread Patch in this message | | | Date | Tue, 12 Jul 2022 15:55:09 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH v7 0/4] tracing/probes: allow no event name input when create group |
| |
On Mon, 27 Jun 2022 10:19:04 +0800 Linyu Yuan <quic_linyyuan@quicinc.com> wrote:
> take kprobe event as example, when create a group of events, > p[:[GRP/]EVENT] [MOD:]KSYM[+OFFS]|KADDR [FETCHARGS], > according to this format, we must input EVENT name, > > this change allow only GRP/ input, EVENT name auto generate from KSYM, > p[:[GRP/][EVENT]] [MOD:]KSYM[+OFFS]|KADDR [FETCHARGS] > > similar change apply to eprobe and uprobe. >
With this patch set applied, this selftest fails:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc
This exactly:
echo 'p:foo/ vfs_read' > kprobe_events
no longer fails as the test expects it to.
I guess we need to remove that check as it now works and no longer fails as "expected".
This change fixes it.
If it's OK with everyone, I'll apply this change.
-- Steve
diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc index fa928b431555..7c02509c71d0 100644 --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_syntax_errors.tc @@ -21,7 +21,6 @@ check_error 'p:^/bar vfs_read' # NO_GROUP_NAME check_error 'p:^12345678901234567890123456789012345678901234567890123456789012345/bar vfs_read' # GROUP_TOO_LONG check_error 'p:^foo.1/bar vfs_read' # BAD_GROUP_NAME -check_error 'p:foo/^ vfs_read' # NO_EVENT_NAME check_error 'p:foo/^12345678901234567890123456789012345678901234567890123456789012345 vfs_read' # EVENT_TOO_LONG check_error 'p:foo/^bar.1 vfs_read' # BAD_EVENT_NAME
| |