Messages in this thread | | | From | "Chanho Park" <> | Subject | RE: [PATCH] time: remove useless "const" keyword in ns_to_kernel_old_timeval() and ns_to_timespec64() | Date | Tue, 12 Jul 2022 16:49:46 +0900 |
| |
> > As mentioned below, > > > https://lore.kernel.org/lkml/CAK8P3a3nknJgEDESGdJH91jMj6R_xydFqWASd8r5Bbes > dvMBgA@mail.gmail.com/
I'm not sure why you drop my originality but please use my commit message and put this link between --- and include/linux/time32.h if you need additional comments. https://lore.kernel.org/all/20220531064346.51677-1-chanho61.park@samsung.com/T/
Indeed you should put Fixes tag for stable tree.
Best Regards, Chanho Park
> > > > The "const" keyword is useless, so we drop it from the function > definition and declaration. > > > > Change-Id: If35bba78aa7757476e22be42afc719c27fb0f527 > > Signed-off-by: Youngmin Nam <youngmin.nam@samsung.com> > > The patch looks good, but the description can be improved: > > - drop the useless Change-Id field > - move the URL into a 'Link: field' > - wrap the lines to fit into the normal width of an email (under 80 > characters, > ideally 70) > - explain why the change helps, rather than just stating the keyword is > useless. > In your description, it's not clear if one is better than the other, it > sounds > like it should make no difference. > > With that done: > > Reviewed-by: Arnd Bergmann <arnd@arndb.de>
| |