Messages in this thread | | | Date | Tue, 12 Jul 2022 18:19:05 +0200 | Subject | Re: [PATCH v2 1/7] iommu/exynos: Reuse SysMMU constants for page size and order | From | Krzysztof Kozlowski <> |
| |
On 11/07/2022 01:05, Sam Protsenko wrote: > Using SZ_4K in context of SysMMU driver is better than using PAGE_SIZE, > as PAGE_SIZE might have different value on different platforms. Though > it would be even better to use more specific constants, already existing > in SysMMU driver. Make the code more strict by using SPAGE_ORDER and > SPAGE_SIZE constants. > > It also makes sense, as __sysmmu_tlb_invalidate_entry() also uses > SPAGE_* constants for further calculations with num_inv param, so it's > logical that num_inv should be previously calculated using also SPAGE_* > values. > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards, Krzysztof
| |