Messages in this thread | | | Date | Mon, 11 Jul 2022 13:06:25 +0200 | Subject | Re: [PATCH 6/6] clk: qcom: apss-ipq-pll: add support for IPQ8074 | From | Krzysztof Kozlowski <> |
| |
On 11/07/2022 12:47, Robert Marko wrote: > Add support for IPQ8074 since it uses the same PLL setup, however it does > not require the Alpha PLL to be reconfigured. > > Signed-off-by: Robert Marko <robimarko@gmail.com> > --- > drivers/clk/qcom/apss-ipq-pll.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/qcom/apss-ipq-pll.c b/drivers/clk/qcom/apss-ipq-pll.c > index bef7899ad0d6..acfb3ec4f142 100644 > --- a/drivers/clk/qcom/apss-ipq-pll.c > +++ b/drivers/clk/qcom/apss-ipq-pll.c > @@ -55,6 +55,7 @@ static const struct regmap_config ipq_pll_regmap_config = { > static int apss_ipq_pll_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > + struct device_node *node = dev->of_node; > struct regmap *regmap; > void __iomem *base; > int ret; > @@ -67,7 +68,8 @@ static int apss_ipq_pll_probe(struct platform_device *pdev) > if (IS_ERR(regmap)) > return PTR_ERR(regmap); > > - clk_alpha_pll_configure(&ipq_pll, regmap, &ipq_pll_config); > + if (of_device_is_compatible(node, "qcom,ipq6018-a53pll"))
Use match data instead with quirks. Better not to encode compatibles all through the code.
Best regards, Krzysztof
| |