Messages in this thread | | | From | Michael Walle <> | Subject | Re: [PATCH] mtd: spi-nor: winbond: add support for W25Q512NW-IQ/IN | Date | Mon, 11 Jul 2022 11:50:42 +0200 |
| |
Hi,
> Add support for Winbond W25Q512NW-IQ/IN > > datasheet: > https://www.winbond.com/resource-files/W25Q512NW%20RevB%2007192021.pdf
Please add that as a Link: tag before your SoB tag.
> Test result on AST2600 SoC's SPI controller: > $ cat /sys/bus/platform/devices/1e620000.spi/spi_master/spi0/spi0.1/spi-nor/jedec_id > ef6020 > > $ cat /sys/bus/platform/devices/1e620000.spi/spi_master/spi0/spi0.1/spi-nor/manufacturer > winbond > > $ cat /sys/bus/platform/devices/1e620000.spi/spi_master/spi0/spi0.1/spi-nor/partname > w25q512nwq > > $ hexdump /sys/bus/platform/devices/1e620000.spi/spi_master/spi0/spi0.1/spi-nor/sfdp > 0000000 4653 5044 0106 ff01 0600 1001 0080 ff00 > 0000010 0084 0201 00d0 ff00 ffff ffff ffff ffff > 0000020 ffff ffff ffff ffff ffff ffff ffff ffff > * > 0000080 20e5 fffb ffff 1fff eb44 6b08 3b08 bb42 > 0000090 fffe ffff ffff 0000 ffff eb40 200c 520f > 00000a0 d810 0000 0233 00a6 e781 d914 63e9 3376 > 00000b0 757a 757a bdf7 5cd5 f719 ff5d 70e9 a5f9 > 00000c0 ffff ffff ffff ffff ffff ffff ffff ffff > 00000d0 0aff fff0 ff21 ffdc > 00000d8
This information goes below the --- line
> Signed-off-by: Jae Hyun Yoo <quic_jaehyoo@quicinc.com> > --- > drivers/mtd/spi-nor/winbond.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c > index ffaa24055259..d6f1a3b7267e 100644 > --- a/drivers/mtd/spi-nor/winbond.c > +++ b/drivers/mtd/spi-nor/winbond.c > @@ -133,6 +133,9 @@ static const struct flash_info winbond_nor_parts[] = { > { "w25m512jv", INFO(0xef7119, 0, 64 * 1024, 1024) > NO_SFDP_FLAGS(SECT_4K | SPI_NOR_QUAD_READ | > SPI_NOR_DUAL_READ) }, > + { "w25q512nwq", INFO(0xef6020, 0, 64 * 1024, 1024)
Please use INFO(0xef6020, 0, 0, 0) and test wether it will still work correctly. We will then be able to convert it to SNOR_ID3() later.
> + PARSE_SFDP > + OTP_INFO(256, 3, 0x1000, 0x1000) },
Did you test OTP?
-michael
> { "w25q512nwm", INFO(0xef8020, 0, 64 * 1024, 1024) > PARSE_SFDP > OTP_INFO(256, 3, 0x1000, 0x1000) }, > -- > 2.25.1
| |