lkml.org 
[lkml]   [2022]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 214/230] i2c: cadence: Unregister the clk notifier in error path
    Date
    From: Satish Nagireddy <satish.nagireddy@getcruise.com>

    [ Upstream commit 3501f0c663063513ad604fb1b3f06af637d3396d ]

    This patch ensures that the clock notifier is unregistered
    when driver probe is returning error.

    Fixes: df8eb5691c48 ("i2c: Add driver for Cadence I2C controller")
    Signed-off-by: Satish Nagireddy <satish.nagireddy@getcruise.com>
    Tested-by: Lars-Peter Clausen <lars@metafoo.de>
    Reviewed-by: Michal Simek <michal.simek@amd.com>
    Signed-off-by: Wolfram Sang <wsa@kernel.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/i2c/busses/i2c-cadence.c | 1 +
    1 file changed, 1 insertion(+)

    diff --git a/drivers/i2c/busses/i2c-cadence.c b/drivers/i2c/busses/i2c-cadence.c
    index b4c1ad19cdae..3d6f8ee355bf 100644
    --- a/drivers/i2c/busses/i2c-cadence.c
    +++ b/drivers/i2c/busses/i2c-cadence.c
    @@ -1338,6 +1338,7 @@ static int cdns_i2c_probe(struct platform_device *pdev)
    return 0;

    err_clk_dis:
    + clk_notifier_unregister(id->clk, &id->clk_rate_change_nb);
    clk_disable_unprepare(id->clk);
    pm_runtime_disable(&pdev->dev);
    pm_runtime_set_suspended(&pdev->dev);
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-07-11 12:04    [W:4.038 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site