Messages in this thread | | | Date | Mon, 11 Jul 2022 08:45:35 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH 1/5] usb: mtu3: fix coverity of string buffer |
| |
On Mon, Jul 11, 2022 at 02:39:10PM +0800, Chunfeng Yun wrote: > On Fri, 2022-07-08 at 09:26 +0200, Greg Kroah-Hartman wrote: > > On Fri, Jul 08, 2022 at 03:18:59PM +0800, Chunfeng Yun wrote: > > > Use snprintf instead of sprintf which could cause buffer overflow. > > > > How can it cause an overflow? > Maybe I didn't describe it clearly, this patch is used to fix coverity > check warning of string buffer, in fact no overflow happens.
Then perhaps the coverity warning is useless and yet-another-false-positive that that tool is known to spit out?
Don't make code changes just because broken tools say to do so.
thanks,
greg k-h
| |