lkml.org 
[lkml]   [2022]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 195/230] pinctrl: sunxi: sunxi_pconf_set: use correct offset
    Date
    From: Andrei Lalaev <andrey.lalaev@gmail.com>

    [ Upstream commit cd4c1e65a32afd003b08ad4aafe1e4d3e4e8e61b ]

    Some Allwinner SoCs have 2 pinctrls (PIO and R_PIO).
    Previous implementation used absolute pin numbering and it was incorrect
    for R_PIO pinctrl.
    It's necessary to take into account the base pin number.

    Fixes: 90be64e27621 ("pinctrl: sunxi: implement pin_config_set")
    Signed-off-by: Andrei Lalaev <andrey.lalaev@gmail.com>
    Reviewed-by: Samuel Holland <samuel@sholland.org>
    Link: https://lore.kernel.org/r/20220525190423.410609-1-andrey.lalaev@gmail.com
    Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
    Signed-off-by: Sasha Levin <sashal@kernel.org>
    ---
    drivers/pinctrl/sunxi/pinctrl-sunxi.c | 2 ++
    1 file changed, 2 insertions(+)

    diff --git a/drivers/pinctrl/sunxi/pinctrl-sunxi.c b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
    index ce3f9ea41511..1431ab21aca6 100644
    --- a/drivers/pinctrl/sunxi/pinctrl-sunxi.c
    +++ b/drivers/pinctrl/sunxi/pinctrl-sunxi.c
    @@ -544,6 +544,8 @@ static int sunxi_pconf_set(struct pinctrl_dev *pctldev, unsigned pin,
    struct sunxi_pinctrl *pctl = pinctrl_dev_get_drvdata(pctldev);
    int i;

    + pin -= pctl->desc->pin_base;
    +
    for (i = 0; i < num_configs; i++) {
    enum pin_config_param param;
    unsigned long flags;
    --
    2.35.1


    \
     
     \ /
      Last update: 2022-07-11 12:02    [W:7.969 / U:0.016 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site