lkml.org 
[lkml]   [2022]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.15 159/230] fbdev: fbmem: Fix logo center image dx issue
    Date
    From: Guiling Deng <greens9@163.com>

    commit 955f04766d4e6eb94bf3baa539e096808c74ebfb upstream.

    Image.dx gets wrong value because of missing '()'.

    If xres == logo->width and n == 1, image.dx = -16.

    Signed-off-by: Guiling Deng <greens9@163.com>
    Fixes: 3d8b1933eb1c ("fbdev: fbmem: add config option to center the bootup logo")
    Cc: stable@vger.kernel.org # v5.0+
    Signed-off-by: Helge Deller <deller@gmx.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/video/fbdev/core/fbmem.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/video/fbdev/core/fbmem.c
    +++ b/drivers/video/fbdev/core/fbmem.c
    @@ -514,7 +514,7 @@ static int fb_show_logo_line(struct fb_i

    while (n && (n * (logo->width + 8) - 8 > xres))
    --n;
    - image.dx = (xres - n * (logo->width + 8) - 8) / 2;
    + image.dx = (xres - (n * (logo->width + 8) - 8)) / 2;
    image.dy = y ?: (yres - logo->height) / 2;
    } else {
    image.dx = 0;

    \
     
     \ /
      Last update: 2022-07-11 11:58    [W:4.151 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site