lkml.org 
[lkml]   [2022]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 5.4 38/38] dmaengine: ti: Add missing put_device in ti_dra7_xbar_route_allocate
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    commit 615a4bfc426e11dba05c2cf343f9ac752fb381d2 upstream.

    of_find_device_by_node() takes reference, we should use put_device()
    to release it when not need anymore.

    Fixes: a074ae38f859 ("dmaengine: Add driver for TI DMA crossbar on DRA7x")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Acked-by: Peter Ujfalusi <peter.ujfalusi@gmail.com>
    Link: https://lore.kernel.org/r/20220605042723.17668-1-linmq006@gmail.com
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/dma/ti/dma-crossbar.c | 4 ++++
    1 file changed, 4 insertions(+)

    --- a/drivers/dma/ti/dma-crossbar.c
    +++ b/drivers/dma/ti/dma-crossbar.c
    @@ -247,6 +247,7 @@ static void *ti_dra7_xbar_route_allocate
    if (dma_spec->args[0] >= xbar->xbar_requests) {
    dev_err(&pdev->dev, "Invalid XBAR request number: %d\n",
    dma_spec->args[0]);
    + put_device(&pdev->dev);
    return ERR_PTR(-EINVAL);
    }

    @@ -254,12 +255,14 @@ static void *ti_dra7_xbar_route_allocate
    dma_spec->np = of_parse_phandle(ofdma->of_node, "dma-masters", 0);
    if (!dma_spec->np) {
    dev_err(&pdev->dev, "Can't get DMA master\n");
    + put_device(&pdev->dev);
    return ERR_PTR(-EINVAL);
    }

    map = kzalloc(sizeof(*map), GFP_KERNEL);
    if (!map) {
    of_node_put(dma_spec->np);
    + put_device(&pdev->dev);
    return ERR_PTR(-ENOMEM);
    }

    @@ -271,6 +274,7 @@ static void *ti_dra7_xbar_route_allocate
    dev_err(&pdev->dev, "Run out of free DMA requests\n");
    kfree(map);
    of_node_put(dma_spec->np);
    + put_device(&pdev->dev);
    return ERR_PTR(-ENOMEM);
    }
    set_bit(map->xbar_out, xbar->dma_inuse);

    \
     
     \ /
      Last update: 2022-07-11 11:18    [W:4.158 / U:0.064 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site