lkml.org 
[lkml]   [2022]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.19 26/31] misc: rtsx_usb: set return value in rsp_buf alloc err path
    Date
    From: Shuah Khan <skhan@linuxfoundation.org>

    commit 2cd37c2e72449a7add6da1183d20a6247d6db111 upstream.

    Set return value in rsp_buf alloc error path before going to
    error handling.

    drivers/misc/cardreader/rtsx_usb.c:639:6: warning: variable 'ret' is used uninitialized whenever 'if' condition is true [-Wsometimes-uninitialized]
    if (!ucr->rsp_buf)
    ^~~~~~~~~~~~~
    drivers/misc/cardreader/rtsx_usb.c:678:9: note: uninitialized use occurs here
    return ret;
    ^~~
    drivers/misc/cardreader/rtsx_usb.c:639:2: note: remove the 'if' if its condition is always false
    if (!ucr->rsp_buf)
    ^~~~~~~~~~~~~~~~~~
    drivers/misc/cardreader/rtsx_usb.c:622:9: note: initialize the variable 'ret' to silence this warning
    int ret;
    ^
    = 0

    Fixes: 3776c7855985 ("misc: rtsx_usb: use separate command and response buffers")
    Reported-by: kernel test robot <lkp@intel.com>
    Cc: stable <stable@kernel.org>
    Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
    Link: https://lore.kernel.org/r/20220701165352.15687-1-skhan@linuxfoundation.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/misc/cardreader/rtsx_usb.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/drivers/misc/cardreader/rtsx_usb.c
    +++ b/drivers/misc/cardreader/rtsx_usb.c
    @@ -647,8 +647,10 @@ static int rtsx_usb_probe(struct usb_int
    return -ENOMEM;

    ucr->rsp_buf = kmalloc(IOBUF_SIZE, GFP_KERNEL);
    - if (!ucr->rsp_buf)
    + if (!ucr->rsp_buf) {
    + ret = -ENOMEM;
    goto out_free_cmd_buf;
    + }

    usb_set_intfdata(intf, ucr);


    \
     
     \ /
      Last update: 2022-07-11 11:14    [W:2.841 / U:24.988 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site