lkml.org 
[lkml]   [2022]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 13/14] dmaengine: ti: Fix refcount leak in ti_dra7_xbar_route_allocate
    Date
    From: Miaoqian Lin <linmq006@gmail.com>

    commit c132fe78ad7b4ce8b5d49a501a15c29d08eeb23a upstream.

    of_parse_phandle() returns a node pointer with refcount
    incremented, we should use of_node_put() on it when not needed anymore.

    Add missing of_node_put() in to fix this.

    Fixes: ec9bfa1e1a79 ("dmaengine: ti-dma-crossbar: dra7: Use bitops instead of idr")
    Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
    Link: https://lore.kernel.org/r/20220605042723.17668-2-linmq006@gmail.com
    Signed-off-by: Vinod Koul <vkoul@kernel.org>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/dma/ti-dma-crossbar.c | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/dma/ti-dma-crossbar.c
    +++ b/drivers/dma/ti-dma-crossbar.c
    @@ -274,6 +274,7 @@ static void *ti_dra7_xbar_route_allocate
    mutex_unlock(&xbar->mutex);
    dev_err(&pdev->dev, "Run out of free DMA requests\n");
    kfree(map);
    + of_node_put(dma_spec->np);
    return ERR_PTR(-ENOMEM);
    }
    set_bit(map->xbar_out, xbar->dma_inuse);

    \
     
     \ /
      Last update: 2022-07-11 11:09    [W:3.945 / U:0.100 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site