lkml.org 
[lkml]   [2022]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.9 02/14] can: grcan: grcan_probe(): remove extra of_node_get()
    Date
    From: Liang He <windhl@126.com>

    commit 562fed945ea482833667f85496eeda766d511386 upstream.

    In grcan_probe(), of_find_node_by_path() has already increased the
    refcount. There is no need to call of_node_get() again, so remove it.

    Link: https://lore.kernel.org/all/20220619070257.4067022-1-windhl@126.com
    Fixes: 1e93ed26acf0 ("can: grcan: grcan_probe(): fix broken system id check for errata workaround needs")
    Cc: stable@vger.kernel.org # v5.18
    Cc: Andreas Larsson <andreas@gaisler.com>
    Signed-off-by: Liang He <windhl@126.com>
    Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/can/grcan.c | 1 -
    1 file changed, 1 deletion(-)

    --- a/drivers/net/can/grcan.c
    +++ b/drivers/net/can/grcan.c
    @@ -1669,7 +1669,6 @@ static int grcan_probe(struct platform_d
    */
    sysid_parent = of_find_node_by_path("/ambapp0");
    if (sysid_parent) {
    - of_node_get(sysid_parent);
    err = of_property_read_u32(sysid_parent, "systemid", &sysid);
    if (!err && ((sysid & GRLIB_VERSION_MASK) >=
    GRCAN_TXBUG_SAFE_GRLIB_VERSION))

    \
     
     \ /
      Last update: 2022-07-11 11:07    [W:3.252 / U:0.688 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site