Messages in this thread | | | Subject | Re: [PATCH] x86/mm/tlb: Skip tracing when flush is not done | From | Nadav Amit <> | Date | Mon, 11 Jul 2022 16:42:14 -0700 |
| |
On Jul 11, 2022, at 3:50 PM, Andy Lutomirski <luto@kernel.org> wrote:
> On 7/10/22 16:33, Nadav Amit wrote: >> From: Nadav Amit <namit@vmware.com> >> Currently, if flush_tlb_func() does not flush for some reason, the >> tracing of the flush will be done only in certain cases, depending on >> the reason of the flush. Be consistent and just do not trace in all >> cases when the flush was eventually not done. >> Suggested-by: Dave Hansen <dave.hansen@linux.intel.com> >> Cc: Peter Zijlstra (Intel) <peterz@infradead.org> >> Cc: Andy Lutomirski <luto@kernel.org> >> Signed-off-by: Nadav Amit <namit@vmware.com> > > > Can you remove this comment, too? > >> /* Tracing is done in a unified manner to reduce the code size */
Yes. I will send v2.
… And if you have time, can you please review the other TLB patch that I sent? It is a really urgent one.
Thanks, Nadav
| |