lkml.org 
[lkml]   [2022]   [Jul]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 -next 1/1] module: kallsyms: Ensure preemption in add_kallsyms() with PREEMPT_RT
On Mon, Jul 11, 2022 at 06:17:19PM +0100, Aaron Tomlin wrote:
> The commit 08126db5ff73 ("module: kallsyms: Fix suspicious rcu usage")
> under PREEMPT_RT=y, disabling preemption introduced an unbounded
> latency since the loop is not fixed. This change caused a regression
> since previously preemption was not disabled and we would dereference
> RCU-protected pointers explicitly. That being said, these pointers
> cannot change.
>
> Before kallsyms-specific data is prepared/or set-up, we ensure that
> the unformed module is known to be unique i.e. does not already exist
> (see load_module()). Therefore, we can fix this by using the common and
> more appropriate RCU flavour as this section of code can be safely
> preempted.
>
> Reported-by: Steven Rostedt <rostedt@goodmis.org>
> Fixes: 08126db5ff73 ("module: kallsyms: Fix suspicious rcu usage")
> Signed-off-by: Aaron Tomlin <atomlin@redhat.com>

Thanks! Queued up!

Luis

\
 
 \ /
  Last update: 2022-07-11 19:33    [W:0.124 / U:0.992 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site