Messages in this thread Patch in this message | | | From | Andrey Strachuk <> | Subject | [PATCH] usb: musb: remove useless condition from musb_gadget_dequeue() | Date | Mon, 11 Jul 2022 18:17:36 +0300 |
| |
Comparison of 'ep' with NULL is useless since 'ep' is a result of container_of and cannot be NULL in any reasonable scenario.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Andrey Strachuk <strochuk@ispras.ru> Fixes: 47e9760529a9 ("USB: musb_gadget: implement set_wedge() method") --- drivers/usb/musb/musb_gadget.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c index 51274b87f46c..32447b7b1976 100644 --- a/drivers/usb/musb/musb_gadget.c +++ b/drivers/usb/musb/musb_gadget.c @@ -1271,7 +1271,7 @@ static int musb_gadget_dequeue(struct usb_ep *ep, struct usb_request *request) int status = 0; struct musb *musb = musb_ep->musb; - if (!ep || !request || req->ep != musb_ep) + if (!request || req->ep != musb_ep) return -EINVAL; trace_musb_req_deq(req); -- 2.25.1
| |