Messages in this thread | | | Date | Mon, 11 Jul 2022 22:22:57 +0800 | Subject | Re: [PATCH] extcon: Add EXTCON_DISP_CVBS and EXTCON_DISP_EDP | From | Michael Wu <> |
| |
On 7/9/2022 9:03 AM, Chanwoo Choi wrote: > On 22. 7. 8. 18:57, Michael Wu wrote: >> Add EXTCON_DISP_CVBS for Composite Video Broadcast Signal. >> Add EXTCON_DISP_EDP for Embedded Display Port >> >> [1] https://en.wikipedia.org/wiki/Composite_video >> [2] https://en.wikipedia.org/wiki/DisplayPort#eDP >> >> Signed-off-by: Michael Wu <michael@allwinnertech.com> >> --- >> drivers/extcon/extcon.c | 10 ++++++++++ >> include/linux/extcon.h | 2 ++ >> 2 files changed, 12 insertions(+) >> >> diff --git a/drivers/extcon/extcon.c b/drivers/extcon/extcon.c >> index d3a32b8064994..774607a616f7b 100644 >> --- a/drivers/extcon/extcon.c >> +++ b/drivers/extcon/extcon.c >> @@ -167,6 +167,16 @@ static const struct __extcon_info { >> .id = EXTCON_DISP_HMD, >> .name = "HMD", >> }, >> + [EXTCON_DISP_CVBS] = { >> + .type = EXTCON_TYPE_DISP, >> + .id = EXTCON_DISP_CVBS, >> + .name = "CVBS", >> + }, >> + [EXTCON_DISP_EDP] = { >> + .type = EXTCON_TYPE_DISP, >> + .id = EXTCON_DISP_EDP, >> + .name = "EDP", >> + }, >> >> /* Miscellaneous external connector */ >> [EXTCON_DOCK] = { >> diff --git a/include/linux/extcon.h b/include/linux/extcon.h >> index 685401d94d398..3c45c3846fe94 100644 >> --- a/include/linux/extcon.h >> +++ b/include/linux/extcon.h >> @@ -76,6 +76,8 @@ >> #define EXTCON_DISP_VGA 43 /* Video Graphics Array */ >> #define EXTCON_DISP_DP 44 /* Display Port */ >> #define EXTCON_DISP_HMD 45 /* Head-Mounted Display */ >> +#define EXTCON_DISP_CVBS 46 /* Composite Video Broadcast Signal */ >> +#define EXTCON_DISP_EDP 47 /* Embedded Display Port */ >> >> /* Miscellaneous external connector */ >> #define EXTCON_DOCK 60 > > Applied it. Thanks. > > Do you have a plan to send extcon driver with newly added connector type? >
Hi Chanwoo, Thank you for the inviting. I'd like to send more patches for extcon, unfortunately the SoCs I'm using only covers CVBS and EDP among the new connector types. Once I had a chance to verify a new type, I'll surely send it here. BTW, should I send a patch-v2 with 'Reviewed-by Chanwoo Choi <cwchoi00@gmail.com>' or 'Acked-by Chanwoo Choi <cwchoi00@gmail.com>', or should I just wait? Thanks again.
-- Regards, Michael Wu
| |