Messages in this thread | | | Date | Mon, 11 Jul 2022 16:53:47 +0300 | Subject | Re: [PATCH v5 5/5] interconnect: qcom: icc-rpm: Set bandwidth and clock for bucket values | From | Georgi Djakov <> |
| |
Hi Leo,
On 11.07.22 14:52, Leo Yan wrote: > This commit uses buckets for support bandwidth and clock rates. It > introduces a new function qcom_icc_bus_aggregate() to calculate the > aggregate average and peak bandwidths for every bucket, and also it > calculates the maximum value of aggregated average bandwidth across all > buckets. > > The maximum aggregated average is used to calculate the final bandwidth > requests. And we can set the clock rate per bucket, we use SLEEP bucket > as default bucket if a platform doesn't enable the interconnect path > tags in DT binding; otherwise, we use WAKE bucket to set active clock > and use SLEEP bucket for other clocks. So far we don't use AMC bucket. > > Signed-off-by: Leo Yan <leo.yan@linaro.org> > --- > drivers/interconnect/qcom/icc-rpm.c | 75 +++++++++++++++++++++++------ > 1 file changed, 61 insertions(+), 14 deletions(-) > > diff --git a/drivers/interconnect/qcom/icc-rpm.c b/drivers/interconnect/qcom/icc-rpm.c > index d27b1582521f..f15f5deee6ef 100644 > --- a/drivers/interconnect/qcom/icc-rpm.c > +++ b/drivers/interconnect/qcom/icc-rpm.c > @@ -302,18 +302,57 @@ static int qcom_icc_bw_aggregate(struct icc_node *node, u32 tag, u32 avg_bw, > return 0; > } > > +/** > + * qcom_icc_bus_aggregate - aggregate bandwidth by traversing all nodes > + * @provider: generic interconnect provider > + * @agg_avg: an array for aggregated average bandwidth of buckets > + * @agg_peak: an array for aggregated peak bandwidth of buckets > + * @max_agg_avg: pointer to max value of aggregated average bandwidth > + */ > +static void qcom_icc_bus_aggregate(struct icc_provider *provider, > + u64 *agg_avg, u64 *agg_peak, > + u64 *max_agg_avg) > +{ > + struct icc_node *node; > + struct qcom_icc_node *qn; > + int i; > + > + /* Initialise aggregate values */ > + for (i = 0; i < QCOM_ICC_NUM_BUCKETS; i++) { > + agg_avg[i] = 0; > + agg_peak[i] = 0; > + } > + > + *max_agg_avg = 0; > + > + /* > + * Iterate nodes on the interconnect and aggregate bandwidth > + * requests for every bucket. > + */ > + list_for_each_entry(node, &provider->nodes, node_list) { > + qn = node->data; > + for (i = 0; i < QCOM_ICC_NUM_BUCKETS; i++) { > + agg_avg[i] += qn->sum_avg[i]; > + agg_peak[i] = max_t(u64, agg_peak[i], qn->max_peak[i]); > + } > + } > + > + /* Find maximum values across all buckets */ > + for (i = 0; i < QCOM_ICC_NUM_BUCKETS; i++) > + *max_agg_avg = max_t(u64, *max_agg_avg, agg_avg[i]); > +} > + > static int qcom_icc_set(struct icc_node *src, struct icc_node *dst) > { > struct qcom_icc_provider *qp; > struct qcom_icc_node *src_qn = NULL, *dst_qn = NULL; > struct icc_provider *provider; > - struct icc_node *n; > u64 sum_bw; > - u64 max_peak_bw; > u64 rate; > - u32 agg_avg = 0; > - u32 agg_peak = 0; > + u64 agg_avg[QCOM_ICC_NUM_BUCKETS], agg_peak[QCOM_ICC_NUM_BUCKETS]; > + u64 max_agg_avg, max_agg_peak;
Now max_agg_peak is unused?
Thanks, Georgi
| |