Messages in this thread | | | From | Linus Walleij <> | Date | Mon, 11 Jul 2022 14:42:48 +0200 | Subject | Re: [PATCH] pinctrl: ralink: Check for null return of devm_kcalloc |
| |
On Sun, Jul 10, 2022 at 5:49 PM <williamsukatube@163.com> wrote:
> From: William Dean <williamsukatube@gmail.com> > > Because of the possible failure of the allocation, data->domains might > be NULL pointer and will cause the dereference of the NULL pointer > later. > Therefore, it might be better to check it and directly return -ENOMEM > without releasing data manually if fails, because the comment of the > devm_kmalloc() says "Memory allocated with this function is > automatically freed on driver detach.". > > Fixes: a86854d0c599b ("treewide: devm_kzalloc() -> devm_kcalloc()") > Reported-by: Hacash Robot <hacashRobot@santino.com> > Signed-off-by: William Dean <williamsukatube@gmail.com>
Patch applied for fixes!
Yours, Linus Walleij
| |