Messages in this thread | | | Date | Mon, 11 Jul 2022 13:57:18 +0200 | From | Oscar Salvador <> | Subject | Re: [PATCH -V2 2/7] migrate_pages(): remove unnecessary list_safe_reset_next() |
| |
On Mon, Jul 11, 2022 at 04:49:43PM +0800, Huang Ying wrote: > Before commit b5bade978e9b ("mm: migrate: fix the return value of > migrate_pages()"), the tail pages of THP will be put in the "from" > list directly. So one of the loop cursors (page2) needs to be reset, > as is done in try_split_thp() via list_safe_reset_next(). But after > the commit, the tail pages of THP will be put in a dedicated > list (thp_split_pages). That is, the "from" list will not be changed > during splitting. So, it's unnecessary to call list_safe_reset_next() > anymore. > > This is a code cleanup, no functionality changes are expected. > > Signed-off-by: "Huang, Ying" <ying.huang@intel.com> > Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com> > Cc: Zi Yan <ziy@nvidia.com> > Cc: Yang Shi <shy828301@gmail.com>
Reviewed-by: Oscar Salvador <osalvador@suse.de>
-- Oscar Salvador SUSE Labs
| |