Messages in this thread | | | From | Dexuan Cui <> | Subject | RE: [Patch v4 07/12] net: mana: Export Work Queue functions for use by RDMA driver | Date | Mon, 11 Jul 2022 01:31:35 +0000 |
| |
> From: longli@linuxonhyperv.com <longli@linuxonhyperv.com> > Sent: Wednesday, June 15, 2022 7:07 PM > @@ -125,6 +125,7 @@ int mana_gd_send_request(struct gdma_context *gc, > u32 req_len, const void *req, > > return mana_hwc_send_request(hwc, req_len, req, resp_len, resp); > } > +EXPORT_SYMBOL(mana_gd_send_request); Can we use EXPORT_SYMBOL_GPL?
> @@ -715,9 +715,10 @@ static int mana_create_wq_obj(struct > mana_port_context *apc, > out: > return err; > } > +EXPORT_SYMBOL_GPL(mana_create_wq_obj);
Well, here we use EXPORT_SYMBOL_GPL. If there is a rule to decide which one should be used, please add a comment.
In general, the patch looks good to me.
Reviewed-by: Dexuan Cui <decui@microsoft.com>
| |