Messages in this thread | | | Date | Mon, 11 Jul 2022 09:23:40 +0800 | Subject | Re: [PATCH -next] scsi: ufs: ufs-mediatek: Fix build error | From | Ren Zhijie <> |
| |
Hi,
Just friendly ping...
在 2022/7/4 10:56, Ren Zhijie 写道: > If CONFIG_PM is not set, > make ARCH=arm64 CROSS_COMPILE=aarch64-linux-gnu-, will be failed, like this: > drivers/ufs/host/ufs-mediatek.c: In function ‘ufs_mtk_runtime_suspend’: > drivers/ufs/host/ufs-mediatek.c:1435:8: error: implicit declaration of function ‘ufshcd_runtime_suspend’; did you mean ‘ufs_mtk_runtime_suspend’? [-Werror=implicit-function-declaration] > ret = ufshcd_runtime_suspend(dev); > ^~~~~~~~~~~~~~~~~~~~~~ > ufs_mtk_runtime_suspend > drivers/ufs/host/ufs-mediatek.c: In function ‘ufs_mtk_runtime_resume’: > drivers/ufs/host/ufs-mediatek.c:1450:9: error: implicit declaration of function ‘ufshcd_runtime_resume’; did you mean ‘ufs_mtk_runtime_resume’? [-Werror=implicit-function-declaration] > return ufshcd_runtime_resume(dev); > ^~~~~~~~~~~~~~~~~~~~~ > ufs_mtk_runtime_resume > At top level: > drivers/ufs/host/ufs-mediatek.c:1444:12: error: ‘ufs_mtk_runtime_resume’ defined but not used [-Werror=unused-function] > static int ufs_mtk_runtime_resume(struct device *dev) > ^~~~~~~~~~~~~~~~~~~~~~ > drivers/ufs/host/ufs-mediatek.c:1430:12: error: ‘ufs_mtk_runtime_suspend’ defined but not used [-Werror=unused-function] > static int ufs_mtk_runtime_suspend(struct device *dev) > ^~~~~~~~~~~~~~~~~~~~~~~ > cc1: all warnings being treated as errors > > The declarations of func "ufshcd_runtime_suspend()" and "ufshcd_runtime_resume()" depended on CONFIG_PM, so the function wrappers "ufs_mtk_runtime_suspend()" and "ufs_mtk_runtime_resume()" both should warpped by CONFIG_PM too. > > Reported-by: Hulk Robot <hulkci@huawei.com> > Fixes: e7bf1d50063c ("scsi: ufs: ufs-mediatek: Fix build warnings") > Signed-off-by: Ren Zhijie <renzhijie2@huawei.com> > --- > drivers/ufs/host/ufs-mediatek.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/ufs/host/ufs-mediatek.c b/drivers/ufs/host/ufs-mediatek.c > index c958279bdd8f..e006c2528a3a 100644 > --- a/drivers/ufs/host/ufs-mediatek.c > +++ b/drivers/ufs/host/ufs-mediatek.c > @@ -1427,6 +1427,7 @@ static int ufs_mtk_system_resume(struct device *dev) > } > #endif > > +#ifdef CONFIG_PM > static int ufs_mtk_runtime_suspend(struct device *dev) > { > struct ufs_hba *hba = dev_get_drvdata(dev); > @@ -1449,6 +1450,7 @@ static int ufs_mtk_runtime_resume(struct device *dev) > > return ufshcd_runtime_resume(dev); > } > +#endif > > static const struct dev_pm_ops ufs_mtk_pm_ops = { > SET_SYSTEM_SLEEP_PM_OPS(ufs_mtk_system_suspend,
| |