lkml.org 
[lkml]   [2022]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] dmaengine: fsl-edma: remove redundant assignment to pointer last_sg
On 14-06-22, 19:47, Colin Ian King wrote:
> The pointer last_sg is being assigned a value at the start of a loop
> however it is never read and is being re-assigned later on in both
> brances of an if-statement. The assignment is redundant and can be
> removed.

Applied, thanks

>
> Cleans up clang scan-build warning:
> drivers/dma/fsl-edma-common.c:563:3: warning: Value stored to 'last_sg'
> is never read [deadcode.DeadStores]
>
> Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
> ---
> drivers/dma/fsl-edma-common.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/dma/fsl-edma-common.c b/drivers/dma/fsl-edma-common.c
> index 3ae05d1446a5..a06a1575a2a5 100644
> --- a/drivers/dma/fsl-edma-common.c
> +++ b/drivers/dma/fsl-edma-common.c
> @@ -559,9 +559,6 @@ struct dma_async_tx_descriptor *fsl_edma_prep_slave_sg(
> }
>
> for_each_sg(sgl, sg, sg_len, i) {
> - /* get next sg's physical address */
> - last_sg = fsl_desc->tcd[(i + 1) % sg_len].ptcd;
> -
> if (direction == DMA_MEM_TO_DEV) {
> src_addr = sg_dma_address(sg);
> dst_addr = fsl_chan->dma_dev_addr;
> --
> 2.35.3

--
~Vinod

\
 
 \ /
  Last update: 2022-07-01 18:41    [W:0.026 / U:1.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site