Messages in this thread | | | From | Jim Quinlan <> | Date | Fri, 1 Jul 2022 11:03:38 -0400 | Subject | Re: [PATCH v2 0/2] Add SCMI full message tracing |
| |
Hi, LGTM, I appreciate this change. For testing, I fed your sample output to this:
perl -MData::Dumper -nae 's/^.+scmi_msg_dump:// && print Dumper { (map { split /=/; } split" ") }' < scmi.txt
which gives this
$VAR1 = { 'pt' => '15', 'seq' => '0000', 'pyld' => '000000000800000009daffffffffffff008268d4c075fd1611daffffffffffff008268d4c075fd1619daffffffffffff008268d4c075fd16', 'msg_id' => '01', 's' => '0', 't' => 'NOTI' }; which is what I wanted. BTW, if I ever write a script that would take this SCMI trace text and decode it to nice cmd names and arguments -- where would I submit such a script?
Thanks and Regards, Jim Quinlan Broadcom STB
On Fri, Jul 1, 2022 at 9:54 AM Sudeep Holla <sudeep.holla@arm.com> wrote: > > On Thu, Jun 30, 2022 at 06:31:33PM +0100, Cristian Marussi wrote: > > Hi, > > > > after a few recent troubles handling too strictly out-of-spec replies from > > SCMI servers deployed in the wild, I though it could have been useful to > > have a basic way to dump at will the effective full payloads of > > successfully transmitted/received SCMI messages. > > > > The existing SCMI traces already collect a bunch of information about SCMI > > message exchanges but they do NOT keep any payload information: this is > > certainly preferable most of the time since dumping full SCMI messages to > > the trace buffer involves a full copy of the payload. > > > > For this reason I added a new distinct trace_scmi_msg_dump with this series > > in order to be able to selectively enable at will message dumping only when > > required. > > > > Only successfully transmitted and received (valid) xfers are dumped. > > Looks good to me. I would like to hear from Jim if possible. I plan to > merge this ASAP. > > -- > Regards, > Sudeep [unhandled content-type:application/pkcs7-signature] | |