Messages in this thread | | | Date | Fri, 1 Jul 2022 14:54:11 +0100 | From | Sudeep Holla <> | Subject | Re: [PATCH v2 0/2] Add SCMI full message tracing |
| |
On Thu, Jun 30, 2022 at 06:31:33PM +0100, Cristian Marussi wrote: > Hi, > > after a few recent troubles handling too strictly out-of-spec replies from > SCMI servers deployed in the wild, I though it could have been useful to > have a basic way to dump at will the effective full payloads of > successfully transmitted/received SCMI messages. > > The existing SCMI traces already collect a bunch of information about SCMI > message exchanges but they do NOT keep any payload information: this is > certainly preferable most of the time since dumping full SCMI messages to > the trace buffer involves a full copy of the payload. > > For this reason I added a new distinct trace_scmi_msg_dump with this series > in order to be able to selectively enable at will message dumping only when > required. > > Only successfully transmitted and received (valid) xfers are dumped.
Looks good to me. I would like to hear from Jim if possible. I plan to merge this ASAP.
-- Regards, Sudeep
| |