lkml.org 
[lkml]   [2022]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] arm64: dts: qcom/sdm845-shift-axolotl: Enable pmi9889 LPG LED
From
Date
On Thu, 2022-06-30 at 16:56 -0500, Bjorn Andersson wrote:
> On Thu 12 May 00:44 CDT 2022, Dylan Van Assche wrote:
>
> > Enables the RGB notification LED on the SHIFT 6mq (sdm845-shift-
> > axolotl)
> > with the Qualcomm Light Pulse Generator bindings by Bjorn Andersson
> > [1].
> > Patches are merged in for-next branch of linux-leds.
> > Tested these changes on the SHIFT 6mq.
> >
> > [1]
> > https://git.kernel.org/pub/scm/linux/kernel/git/pavel/linux-leds.git/commit/?h=for-next&id=a8e53db46f19f67be6a26488aafb7d10c78e33bd
> >
> > Signed-off-by: Dylan Van Assche <me@dylanvanassche.be>
> > ---
> >  .../boot/dts/qcom/sdm845-shift-axolotl.dts    | 29
> > +++++++++++++++++++
> >  1 file changed, 29 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> > b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> > index 847f6217a77b..af412ac2c9d0 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts
> > @@ -2,11 +2,13 @@
> >  /*
> >   * Copyright (c) 2022, Alexander Martinz
> > <amartinz@shiftphones.com>
> >   * Copyright (c) 2022, Caleb Connolly <caleb@connolly.tech>
> > + * Copyright (c) 2022, Dylan Van Assche <me@dylanvanassche.be>
> >   */
> >  
> >  /dts-v1/;
> >  
> >  #include <dt-bindings/gpio/gpio.h>
> > +#include <dt-bindings/leds/common.h>
> >  #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
> >  #include "sdm845.dtsi"
> >  #include "pm8998.dtsi"
> > @@ -554,6 +556,33 @@ &pmi8998_smb2 {
> >         monitored-battery = <&battery>;
> >  };
> >  
> > +&pmi8998_lpg {
>
> We don't have this node, because no one has reviewed
> https://lore.kernel.org/all/20220505022706.1692554-1-bjorn.andersson@linaro.org/#t
> yet.
>
> If anyone could take a look I'd be happy to merge this as well.
>
> Thanks,
> Bjorn
>

I had a look, looks fine to me so I sent a Reviewed-by out.
Thanks!

Dylan

> > +       status = "okay";
> > +
> > +       multi-led {
> > +               color = <LED_COLOR_ID_RGB>;
> > +               function = LED_FUNCTION_STATUS;
> > +
> > +               #address-cells = <1>;
> > +               #size-cells = <0>;
> > +
> > +               led@3 {
> > +                       reg = <3>;
> > +                       color = <LED_COLOR_ID_BLUE>;
> > +               };
> > +
> > +               led@4 {
> > +                       reg = <4>;
> > +                       color = <LED_COLOR_ID_GREEN>;
> > +               };
> > +
> > +               led@5 {
> > +                       reg = <5>;
> > +                       color = <LED_COLOR_ID_RED>;
> > +               };
> > +       };
> > +};
> > +
> >  &qup_uart9_default {
> >         pinconf-rx {
> >                 pins = "gpio5";
> > --
> > 2.36.1
> >

\
 
 \ /
  Last update: 2022-07-01 08:10    [W:0.091 / U:2.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site