Messages in this thread | | | From | Andy Shevchenko <> | Date | Fri, 1 Jul 2022 13:07:34 +0200 | Subject | Re: [PATCH v3] hisi_lpc: Use acpi_dev_for_each_child() |
| |
On Fri, Jul 1, 2022 at 1:06 PM Andy Shevchenko <andy.shevchenko@gmail.com> wrote: > On Fri, Jul 1, 2022 at 1:04 PM John Garry <john.garry@huawei.com> wrote: > > On 30/06/2022 19:13, Rafael J. Wysocki wrote: > > ... > > > However Yang Yingliang spotted a pre-existing bug in the ACPI probe and > > sent a fix today (coincidence?): > > > > https://lore.kernel.org/lkml/20220701094352.2104998-1-yangyingliang@huawei.com/T/#u > > > > And they conflict. This code has been this way for years, so I just > > suggest Yang Yingliang resends the fix on top off Rafael's change. > > Wondering if Yang can actually switch that to use > platform_device_register_full().
And for the record, I think the Fixes even for very rare bug hits should go first.
-- With Best Regards, Andy Shevchenko
| |