Messages in this thread | | | From | Chen-Yu Tsai <> | Subject | [PATCH 0/6] media: mediatek-vcodec: Fix capability fields again | Date | Fri, 1 Jul 2022 18:52:31 +0800 |
| |
Hi everyone,
The previous round of changes to the mtk-vcodec driver's returned capabilities caused some issues for ChromeOS. In particular, the ChromeOS stateless video decoder uses the "Driver Name" field to match a video device to its media device. As the field was only changed for the video device and not the media device, a match could no longer be found.
While fixing this, I found that the current info used for the fields don't make a lot of sense, and tried to fix them in this series.
Patch 1 reverts the driver name field change. It also makes it explicit that the field really should match the driver name.
Patch 2 changes the value for the card name, making it a free form string that includes the SoC model.
Patch 3 removes setting the bus_info field, instead using the default value derived from the underlying |struct device| as set by the V4L2 core.
Patches 4 through 6 do the same as 1 through 3 respectively, but for the encoder side.
This series is based on next-20220701, and was tested on mainline on MT8183 Juniper, and on ChromeOS v5.10, on which we have a whole bunch of backports pending, on MT8195 Tomato.
Please have a look.
Thanks ChenYu
Chen-Yu Tsai (6): media: mediatek: vcodec: Revert driver name change in decoder capabilities media: mediatek: vcodec: Use meaningful decoder card name including chip name media: mediatek: vcodec: Use default bus_info for decoder capability media: mediatek: vcodec: Revert driver name change in encoder capabilities media: mediatek: vcodec: Use meaningful encoder card name including chip name media: mediatek: vcodec: Use default bus_info for encoder capability
drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec.c | 7 ++++--- drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h | 1 + drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc.c | 7 ++++--- 3 files changed, 9 insertions(+), 6 deletions(-)
-- 2.37.0.rc0.161.g10f37bed90-goog
| |