lkml.org 
[lkml]   [2022]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2 2/4] mfd: rt5120: Add Richtek PMIC support
Lee Jones <lee.jones@linaro.org> 於 2022年7月1日 週五 下午3:38寫道:
>
> On Fri, 01 Jul 2022, ChiYuan Huang wrote:
>
> > HI, Lee:
> >
> > ChiYuan Huang <u0084500@gmail.com> 於 2022年6月27日 週一 晚上10:56寫道:
> > >
> > > Lee Jones <lee.jones@linaro.org> 於 2022年6月27日 週一 晚上10:22寫道:
> > > >
> > > > On Wed, 22 Jun 2022, cy_huang wrote:
> > > >
> > > > > From: ChiYuan Huang <cy_huang@richtek.com>
> > > > >
> > > > > Add Richtek RT5120 PMIC I2C driver.
> > > >
> > > > Why a whole new driver?
> > > >
> > > > How different is this to rt5033?
> > > >
> > > > Looks like this could easily be woven into this existing support?
> > > >
> > > It's different with the function domain.
> > > RT5033 is most like as the SubPMIC that includes PMU (battery
> > > charger/gauge/led/few buck and ldo)
> > > RT5120 is a main PMIC with default-on power that follows the boot on sequence.
> > > RT5120 only integrates regulator and power key report module.
> > >
> > Since I have explained the chip difference, do you still think it's
> > better to merge this code into rt5033 mfd?
>
> I think it's okay to group devices which are similar but not exactly
> the same, if they can be. The integration of this device into the
> other looks trivial to my naive eyes.
>
> A PMIC is a PMIC, main or sub.
>
M.. ok. I will try to group all chip changes like as devices
list/regmap_irq/regmap_config ..., etc.
Treat it as one set of chip config and use 'of_device_get_match_data'
to get the chip config data.

> > > > > Signed-off-by: ChiYuan Huang <cy_huang@richtek.com>
> > > > > ---
> > > > > drivers/mfd/Kconfig | 12 +++++
> > > > > drivers/mfd/Makefile | 1 +
> > > > > drivers/mfd/rt5120.c | 125 +++++++++++++++++++++++++++++++++++++++++++++++++++
> > > > > 3 files changed, 138 insertions(+)
> > > > > create mode 100644 drivers/mfd/rt5120.c
>
> --
> Lee Jones [李琼斯]
> Principal Technical Lead - Developer Services
> Linaro.org │ Open source software for Arm SoCs
> Follow Linaro: Facebook | Twitter | Blog

\
 
 \ /
  Last update: 2022-07-01 11:58    [W:1.705 / U:2.840 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site