lkml.org 
[lkml]   [2022]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH V2 24/30] serial: qcom: Migrate to dev_pm_opp_set_config()
    On Fri, Jul 01, 2022 at 01:50:19PM +0530, Viresh Kumar wrote:
    > The OPP core now provides a unified API for setting all configuration
    > types, i.e. dev_pm_opp_set_config().
    >
    > Lets start using it.
    >
    > Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
    > ---
    > drivers/tty/serial/qcom_geni_serial.c | 6 +++++-
    > 1 file changed, 5 insertions(+), 1 deletion(-)
    >
    > diff --git a/drivers/tty/serial/qcom_geni_serial.c b/drivers/tty/serial/qcom_geni_serial.c
    > index 4733a233bd0c..ab667838d082 100644
    > --- a/drivers/tty/serial/qcom_geni_serial.c
    > +++ b/drivers/tty/serial/qcom_geni_serial.c
    > @@ -1347,6 +1347,10 @@ static int qcom_geni_serial_probe(struct platform_device *pdev)
    > int irq;
    > bool console = false;
    > struct uart_driver *drv;
    > + struct dev_pm_opp_config config = {
    > + .clk_names = (const char *[]){ "se" },
    > + .clk_count = 1,
    > + };
    >
    > if (of_device_is_compatible(pdev->dev.of_node, "qcom,geni-debug-uart"))
    > console = true;
    > @@ -1430,7 +1434,7 @@ static int qcom_geni_serial_probe(struct platform_device *pdev)
    > if (of_property_read_bool(pdev->dev.of_node, "cts-rts-swap"))
    > port->cts_rts_swap = true;
    >
    > - ret = devm_pm_opp_set_clkname(&pdev->dev, "se");
    > + ret = devm_pm_opp_set_config(&pdev->dev, &config);

    This feels like a step back. This is much harder now, what's wrong with
    devm_pm_opp_set_clkname() as is?

    thanks,

    greg k-h

    \
     
     \ /
      Last update: 2022-07-01 10:45    [W:4.062 / U:0.596 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site