Messages in this thread | | | From | "Tian, Kevin" <> | Subject | RE: [PATCH v3 11/11] iommu/vt-d: Convert global spinlock into per domain lock | Date | Fri, 1 Jul 2022 08:18:48 +0000 |
| |
> From: Lu Baolu <baolu.lu@linux.intel.com> > Sent: Wednesday, June 29, 2022 3:47 PM > > Using a global device_domain_lock spinlock to protect per-domain device > tracking lists is an inefficient way, especially considering this lock > is also needed in the hot paths. This optimizes the locking mechanism > by converting the global lock to per domain lock. > > On the other hand, as the device tracking lists are never accessed in > any interrupt context, there is no need to disable interrupts while > spinning. Replace irqsave variant with spinlock calls. > > Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
except the previous comment on where to convert spin_lock_irqsave() the rest looks good to me.
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
| |