lkml.org 
[lkml]   [2022]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v5 3/5] scsi: core: Cap shost max_sectors according to DMA limits only once
From
On 01/07/2022 00:41, Damien Le Moal wrote:
>>
>> shost->dma_dev = dma_dev;
>>
>> + if (dma_dev->dma_mask) {
>> + shost->max_sectors = min_t(unsigned int, shost->max_sectors,
>> + dma_max_mapping_size(dma_dev) >> SECTOR_SHIFT);
>> + }
> Nit: you could remove the curly brackets... But it being a multi-line
> statement, having them is OK too I think.
>

tglx seems to think that they are ok, and I generally agree (now):

https://lore.kernel.org/linux-arm-kernel/877djwdorz.ffs@nanos.tec.linutronix.de/

AFAICT coding-style.rst is ok with them in this scenario too

Cheers,
John

\
 
 \ /
  Last update: 2022-07-01 10:03    [W:0.043 / U:1.164 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site