lkml.org 
[lkml]   [2022]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 02/11] arm64: dts: mediatek: Introduce MT8195 Cherry platform's Tomato
    On Thu, Jun 30, 2022 at 05:33:07PM +0200, AngeloGioacchino Del Regno wrote:
    > Introduce the MT8195 Cherry Chromebook platform, including three
    > revisions of Cherry Tomato boards.
    >
    > This basic configuration allows to boot Linux on all board revisions
    > and get a serial console from a ramdisk.
    >
    > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
    > ---
    > arch/arm64/boot/dts/mediatek/Makefile | 3 +++
    > .../dts/mediatek/mt8195-cherry-tomato-r1.dts | 11 ++++++++
    > .../dts/mediatek/mt8195-cherry-tomato-r2.dts | 11 ++++++++
    > .../dts/mediatek/mt8195-cherry-tomato-r3.dts | 12 +++++++++
    > .../boot/dts/mediatek/mt8195-cherry.dtsi | 26 +++++++++++++++++++
    > 5 files changed, 63 insertions(+)
    > create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts
    > create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dts
    > create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dts
    > create mode 100644 arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi
    [..]
    > diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts
    > new file mode 100644
    > index 000000000000..17e9e4d6f6ab
    > --- /dev/null
    > +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dts
    > @@ -0,0 +1,11 @@
    > +// SPDX-License-Identifier: (GPL-2.0 OR MIT)
    > +/*
    > + * Copyright (C) 2021 MediaTek Inc.
    > + */
    > +/dts-v1/;
    > +#include "mt8195-cherry.dtsi"
    > +
    > +/ {
    > + model = "MediaTek Tomato (rev1) board";

    Given that the compatible is "google," I believe we'll want to rename the model
    to "Google Tomato", much like was commented on the Asurada series [1], but
    better to have confirmation from someone from Google. Chen-Yu? :)

    Otherwise,

    Reviewed-by: Nícolas F. R. A. Prado <nfraprado@collabora.com>

    Thanks,
    Nícolas

    [1] https://lore.kernel.org/all/CAGXv+5Gv2pjPXynz6HCdgux+giPDC5qRk+KW1aFduVz82rM=+g@mail.gmail.com/

    > + compatible = "google,tomato-rev1", "google,tomato", "mediatek,mt8195";
    > +};
    [..]
    > --
    > 2.35.1
    >

    \
     
     \ /
      Last update: 2022-07-02 00:12    [W:3.075 / U:0.288 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site