lkml.org 
[lkml]   [2022]   [Jul]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 4/4] selftest: Taint kernel when test module loaded
Hi David,

I love your patch! Yet something to improve:

[auto build test ERROR on masahiroy-kbuild/for-next]
[also build test ERROR on shuah-kselftest/next linus/master v5.19-rc4 next-20220701]
[cannot apply to mcgrof/modules-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url: https://github.com/intel-lab-lkp/linux/commits/David-Gow/panic-Taint-kernel-if-tests-are-run/20220701-164843
base: https://git.kernel.org/pub/scm/linux/kernel/git/masahiroy/linux-kbuild.git for-next
config: alpha-randconfig-r006-20220629 (https://download.01.org/0day-ci/archive/20220702/202207020132.SKDpQP9D-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/42b6461d6cca4baeeeed474b1400e203057c2b9b
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review David-Gow/panic-Taint-kernel-if-tests-are-run/20220701-164843
git checkout 42b6461d6cca4baeeeed474b1400e203057c2b9b
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=alpha SHELL=/bin/bash

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

In file included from lib/test_printf.c:27:
lib/test_printf.c: In function 'test_printf_init':
>> lib/../tools/testing/selftests/kselftest_module.h:45:19: error: 'TAINT_KUNIT' undeclared (first use in this function)
45 | add_taint(TAINT_KUNIT, LOCKDEP_STILL_OK); \
| ^~~~~~~~~~~
lib/test_printf.c:801:1: note: in expansion of macro 'KSTM_MODULE_LOADERS'
801 | KSTM_MODULE_LOADERS(test_printf);
| ^~~~~~~~~~~~~~~~~~~
lib/../tools/testing/selftests/kselftest_module.h:45:19: note: each undeclared identifier is reported only once for each function it appears in
45 | add_taint(TAINT_KUNIT, LOCKDEP_STILL_OK); \
| ^~~~~~~~~~~
lib/test_printf.c:801:1: note: in expansion of macro 'KSTM_MODULE_LOADERS'
801 | KSTM_MODULE_LOADERS(test_printf);
| ^~~~~~~~~~~~~~~~~~~


vim +/TAINT_KUNIT +45 lib/../tools/testing/selftests/kselftest_module.h

40
41 #define KSTM_MODULE_LOADERS(__module) \
42 static int __init __module##_init(void) \
43 { \
44 pr_info("loaded.\n"); \
> 45 add_taint(TAINT_KUNIT, LOCKDEP_STILL_OK); \
46 selftest(); \
47 return kstm_report(total_tests, failed_tests, skipped_tests); \
48 } \
49 static void __exit __module##_exit(void) \
50 { \
51 pr_info("unloaded.\n"); \
52 } \
53 module_init(__module##_init); \
54 module_exit(__module##_exit)
55

--
0-DAY CI Kernel Test Service
https://01.org/lkp

\
 
 \ /
  Last update: 2022-07-01 19:38    [W:0.119 / U:0.884 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site