Messages in this thread | | | Date | Thu, 9 Jun 2022 15:26:26 +0200 | From | Wolfram Sang <> | Subject | Re: [PATCH 2/2] thermal: rcar_gen3_thermal: improve logging during probe |
| |
Hi Geert,
> > - dev_info(dev, "TSC%u: Loaded %d trip points\n", i, ret); > > + dev_info(dev, "Sensor %u: Trip points loaded: %u\n", i, ret); > > I actually prefer the old wording (I'm undecided about "sensor" vs. > "TSC", though, but consistency rules), as it makes it clear "ret" > is the number of trip points, and not a success code.
I think "Sensor" is actually important. E.g. on Spider, Sensor 0 is TSC1 because there is no TSC0. So, the TSC numbering is confusing.
I'll try to reword it so that the number of points becomes clear again.
[unhandled content-type:application/pgp-signature] | |