lkml.org 
[lkml]   [2022]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] thermal: rcar_gen3_thermal: improve logging during probe
Hi Geert,

> > - dev_info(dev, "TSC%u: Loaded %d trip points\n", i, ret);
> > + dev_info(dev, "Sensor %u: Trip points loaded: %u\n", i, ret);
>
> I actually prefer the old wording (I'm undecided about "sensor" vs.
> "TSC", though, but consistency rules), as it makes it clear "ret"
> is the number of trip points, and not a success code.

I think "Sensor" is actually important. E.g. on Spider, Sensor 0 is TSC1
because there is no TSC0. So, the TSC numbering is confusing.

I'll try to reword it so that the number of points becomes clear again.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2022-06-09 15:27    [W:0.096 / U:0.128 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site